Fixes to breaking changes in C3 0.6 -> 0.7:#61
Open
lerno wants to merge 2 commits intotsoding:mainfrom
Open
Conversation
1. Changed generic syntax from (< >) to { }
2. HashMap and List now default to the temp allocator instead of the heap allocator. This makes sense for casual use, but for the Koil code the assumption was that they would heap allocate, so globals are initialized to map::ONHEAP and list::ONHEAP which will default to heap when first used. This allows the code to mostly be unchanged and not need an explicit .init() of the globals. The exception is `scene` where it seemed more natural to do an explicit `init(mem)`.
|
Hi @lerno ! I'm curious, what was the reasoning behind the syntax change for generics? |
Author
|
I felt that the I always wanted to find an alternative to (<>), but it has taken until now to find a candidate. |
Change `def` to `alias`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because 0.7 has breaking changes compared to 0.6.x I'm offering this pull request to be used if you want to upgrade to use the C3
masterbranch.I understand you mostly don't do any work with C3 recently, so feel free to ignore this pull request.
Changes are:
scenewhere it seemed more natural to do an explicitinit(mem).